Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide div when there is no links - #20. #23

Closed
wants to merge 1 commit into from
Closed

Hide div when there is no links - #20. #23

wants to merge 1 commit into from

Conversation

saif-malik-01
Copy link
Contributor

hound[bot]
hound bot reviewed Oct 9, 2021
View reviewed changes
src/content.js
@@ -5,10 +5,10 @@ browser.runtime.onMessage.addListener(() => {
});
});

const toggleSidebar = () => {
const toggleSidebar = (length) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

dit7ya
dit7ya requested changes Oct 9, 2021
View reviewed changes
Copy link
Owner

@dit7ya dit7ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

However, the toggleSidebar function is called when the browser action (keyboard shortcut) is triggered as well.

Can you look into that and make the appropriate changes?

@saif-malik-01
Copy link
Contributor Author

Sure, will see and make changes accordingly.

@saif-malik-01 saif-malik-01 mentioned this pull request Oct 11, 2021
Closed
@saif-malik-01 saif-malik-01 mentioned this pull request Oct 11, 2021
Merged
dit7ya added a commit that referenced this pull request Oct 17, 2021
@dit7ya
Merge pull request #25 from saif-malik-01/master
ccfd26a 
Close links div when there is no links - #23
dit7ya added a commit that referenced this pull request Oct 17, 2021
@dit7ya
Revert "Close links div when there is no links - #23"
80b68d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound[bot] left review comments

@dit7ya dit7ya dit7ya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saif-malik-01 @dit7ya